Repository navigation
Update dependencies to their latest versions - #2577
Merged
Merged
Conversation
Member
Author
|
@slnode test please |
1 similar comment
Member
Author
|
@slnode test please |
Rework the test suite to always report errors and correctly signal when async tests are done. This should prevent spurious test failures on CI servers that are difficult to troubleshoot, because the error is reported for different test case.
Contributor
|
LGTM 👍 |
Rework assertions to report helpful messages on failure. Increase the "elapsed" limit from 100ms to 300ms to support our slow CI machines.
Rework the test to always wait for the client request to finish before calling the test done.
Member
Author
|
Yay, loopback itself is green now 💃 @jannyHou I added three more commits, could you please review them? Other than that, I think this patch is ready for landing. |
Member
Author
|
@slnode test please |
Contributor
|
👍 loopback itself are all green. Thank you @bajtos Let's land it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @strongloop/loopback-dev FYI, I think no review is needed